security: fix full audit findings (v0.32.0)

Full list of the audit's confirmed findings and their fixes:

- Stored XSS via unescaped JSON-LD on the public recipe page
  (app/r/[id]/page.tsx) — escape < before injecting.
- CSP allowed unsafe-eval in production — now dev-only (Next prod
  never eval()s; only its HMR does).
- avatarUrl accepted any URL with no ownership check — now takes an
  avatarKey issued by avatar-presign, validated server-side, same
  pattern as recipe/review photos.
- No session revocation on password change/reset — both now revoke
  other sessions (revokeOtherSessions: true, revokeSessionsOnPasswordReset).
- Rate-limit bypass via spoofable X-Forwarded-For — take the last
  (proxy-appended) hop instead of the first (client-supplied) one,
  matching the single-Traefik-hop topology.
- Webhook signing secrets stored plaintext — now AES-256-GCM
  encrypted like every other secret in this app, with a legacy-
  plaintext fallback for pre-existing rows (bare hex has no ":", our
  ciphertext format always does).
- Better Auth's own rate limiter defaulted to in-memory storage,
  ineffective across replicas — now backed by the same Redis as
  lib/rate-limit.ts (secondaryStorage), with storeSessionInDatabase
  explicit so session storage itself doesn't move as a side effect.
- Presigned upload URLs didn't bind the declared file size to the
  actual upload, letting a client under-declare size (and quota
  charge) then PUT an arbitrarily large object — switched to S3
  presigned POST with a signed content-length-range condition,
  enforced by the storage server itself.
- generateMetadata() on the recipe page skipped the visibility
  filter the page body uses, leaking a private recipe's title via
  <title> to any signed-in user with the id.
- Block/unblock had no rate limit, unlike follow/unfollow.
- AI quota was charged even when a user's own BYOK key was used
  (their own credentials/billing) — added an isByok flag through
  the config-resolution chain and skip the charge when set. Also
  wired BYOK into generate/generate-from-idea/translate/import-url,
  which never looked it up at all before.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Arnaud
2026-07-14 15:05:05 +02:00
parent 6f11dc07fd
commit 3042d289a0
42 changed files with 508 additions and 417 deletions
+1 -1
View File
@@ -65,7 +65,7 @@ export async function POST(req: NextRequest, { params }: Params) {
},
{ ...aiConfig, userContext: privateBio ?? undefined },
(session!.user as { locale?: string }).locale ?? "en"
)
), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
const adapted = result.data;
@@ -55,7 +55,7 @@ export async function POST(req: NextRequest) {
},
{ ...config, userContext: privateBio ?? undefined },
locale
)
), { skipQuota: config.isByok }
);
if (!result.ok) return result.response;
const plan = result.data;
+3 -2
View File
@@ -33,7 +33,8 @@ export async function POST(req: NextRequest) {
getUserPrivateBio(session!.user.id),
]);
if (!configResult.ok) return configResult.response;
const model = resolveModel(configResult.data);
const aiConfig = configResult.data;
const model = resolveModel(aiConfig);
const bioContext = buildUserBioContext(privateBio);
const locale = (session!.user as { locale?: string }).locale ?? "en";
const lang = LANG[locale] ?? "English";
@@ -43,7 +44,7 @@ export async function POST(req: NextRequest) {
model,
system: `You are Epicure, a helpful culinary assistant answering general cooking questions — not tied to any specific recipe (techniques, substitutions, timing, equipment, food safety, etc). If asked who you are or what model/AI you're built on, say you're Epicure — never name the underlying model or provider. If a question has nothing to do with cooking or food, politely redirect. Keep answers under 200 words. Respond in ${lang}.${bioContext}`,
prompt: parsed.data.question,
})
}), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
+1 -1
View File
@@ -55,7 +55,7 @@ export async function POST(req: NextRequest, { params }: Params) {
parsed.data.count,
{ ...aiConfig, userContext: privateBio ?? undefined },
(session!.user as { locale?: string }).locale ?? "en"
)
), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
@@ -2,9 +2,10 @@ import { NextRequest, NextResponse } from "next/server";
import { z } from "zod";
import { requireSessionOrApiKey } from "@/lib/api-auth";
import { applyRateLimit } from "@/lib/rate-limit";
import { withAiQuota } from "@/lib/ai/ai-error";
import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
import { generateRecipe } from "@/lib/ai/features/generate-recipe";
import { getUserPrivateBio } from "@/lib/ai/user-bio";
import { withUserKey } from "@/lib/ai/resolve-user-key";
import { db, recipes, recipeIngredients, recipeSteps } from "@epicure/db";
import { parseQuantity } from "@/lib/parse-quantity";
@@ -32,13 +33,18 @@ export async function POST(req: NextRequest) {
const privateBio = await getUserPrivateBio(session!.user.id);
const locale = (session!.user as { locale?: string }).locale ?? "en";
const configResult = await resolveAiConfigOrError(() =>
withUserKey(session!.user.id, { provider: parsed.data.provider, model: parsed.data.model })
);
if (!configResult.ok) return configResult.response;
const aiConfig = configResult.data;
const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
generateRecipe(parsed.data.title, {
provider: parsed.data.provider,
model: parsed.data.model,
...aiConfig,
userContext: privateBio ?? undefined,
language: LANG[locale] ?? "English",
})
}), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
const recipe = result.data;
+10 -4
View File
@@ -2,9 +2,10 @@ import { NextRequest, NextResponse } from "next/server";
import { z } from "zod";
import { requireSessionOrApiKey } from "@/lib/api-auth";
import { applyRateLimit } from "@/lib/rate-limit";
import { withAiQuota } from "@/lib/ai/ai-error";
import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
import { generateRecipe } from "@/lib/ai/features/generate-recipe";
import { getUserPrivateBio } from "@/lib/ai/user-bio";
import { withUserKey } from "@/lib/ai/resolve-user-key";
const Schema = z.object({
prompt: z.string().min(3).max(500),
@@ -29,14 +30,19 @@ export async function POST(req: NextRequest) {
const privateBio = await getUserPrivateBio(session!.user.id);
const configResult = await resolveAiConfigOrError(() =>
withUserKey(session!.user.id, { provider: parsed.data.provider, model: parsed.data.model })
);
if (!configResult.ok) return configResult.response;
const aiConfig = configResult.data;
const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
generateRecipe(parsed.data.prompt, {
provider: parsed.data.provider,
model: parsed.data.model,
...aiConfig,
language: parsed.data.language,
difficulty: parsed.data.difficulty,
userContext: privateBio ?? undefined,
})
}), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
+2 -1
View File
@@ -39,7 +39,8 @@ export async function POST(req: NextRequest) {
}
const result = await withAiQuota(userId, session!.user.tier as "free" | "pro", () =>
importFromPhoto(parsed.data.imageBase64, parsed.data.mimeType, aiConfig, locale)
importFromPhoto(parsed.data.imageBase64, parsed.data.mimeType, aiConfig, locale),
{ skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
const recipe = result.data;
+9 -5
View File
@@ -2,9 +2,10 @@ import { NextRequest, NextResponse } from "next/server";
import { z } from "zod";
import { requireSessionOrApiKey } from "@/lib/api-auth";
import { applyRateLimit } from "@/lib/rate-limit";
import { withAiQuota } from "@/lib/ai/ai-error";
import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
import { importFromUrl } from "@/lib/ai/features/import-url";
import { validateWebhookUrl } from "@/lib/validate-webhook-url";
import { withUserKey } from "@/lib/ai/resolve-user-key";
const Schema = z.object({
url: z.string().url(),
@@ -30,11 +31,14 @@ export async function POST(req: NextRequest) {
const limited = await applyRateLimit(`rl:ai:${session!.user.id}`, 10, 60);
if (limited) return limited;
const configResult = await resolveAiConfigOrError(() =>
withUserKey(session!.user.id, { provider: parsed.data.provider, model: parsed.data.model })
);
if (!configResult.ok) return configResult.response;
const aiConfig = configResult.data;
const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
importFromUrl(parsed.data.url, {
provider: parsed.data.provider,
model: parsed.data.model,
})
importFromUrl(parsed.data.url, aiConfig), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
@@ -88,7 +88,7 @@ export async function POST(req: NextRequest) {
},
{ ...config, userContext: privateBio ?? undefined },
locale
)
), { skipQuota: config.isByok }
);
if (!result.ok) return result.response;
const plan = result.data;
@@ -56,7 +56,7 @@ export async function POST(req: NextRequest, { params }: Params) {
parsed.data.count,
{ ...aiConfig, userContext: privateBio ?? undefined },
(session!.user as { locale?: string }).locale ?? "en"
)
), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
+3 -2
View File
@@ -68,7 +68,8 @@ ${stepList || "None listed"}
getUserPrivateBio(session!.user.id),
]);
if (!configResult.ok) return configResult.response;
const model = resolveModel(configResult.data);
const aiConfig = configResult.data;
const model = resolveModel(aiConfig);
const bioContext = buildUserBioContext(privateBio);
const locale = (session!.user as { locale?: string }).locale ?? "en";
const lang = LANG[locale] ?? "English";
@@ -80,7 +81,7 @@ ${stepList || "None listed"}
${recipeContext}${bioContext}`,
prompt: parsed.data.question,
})
}), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
+3 -2
View File
@@ -42,7 +42,8 @@ export async function POST(req: NextRequest) {
getUserPrivateBio(session!.user.id),
]);
if (!configResult.ok) return configResult.response;
const model = resolveModel(configResult.data);
const aiConfig = configResult.data;
const model = resolveModel(aiConfig);
const bioContext = buildUserBioContext(privateBio);
const userContext = bioContext
@@ -62,7 +63,7 @@ export async function POST(req: NextRequest) {
schema: IdeasSchema,
system: `Respond in ${lang}.`,
prompt,
})
}), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
+1 -1
View File
@@ -55,7 +55,7 @@ export async function POST(req: NextRequest) {
recipe.baseServings,
aiConfig,
(session!.user as { locale?: string }).locale ?? "en"
)
), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
+4 -2
View File
@@ -5,6 +5,7 @@ import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
import { applyRateLimit } from "@/lib/rate-limit";
import { getDefaultProviderWithKey } from "@/lib/ai/resolve-user-key";
import { substituteIngredient } from "@/lib/ai/features/substitute-ingredient";
import type { AiConfig } from "@/lib/ai/factory";
const Schema = z.object({
ingredient: z.string().min(1).max(200),
@@ -28,7 +29,7 @@ export async function POST(req: NextRequest) {
? `recipe "${parsed.data.recipeTitle}"`
: "a general recipe";
let aiConfig;
let aiConfig: AiConfig;
if (parsed.data.provider) {
aiConfig = { provider: parsed.data.provider, model: parsed.data.model };
} else {
@@ -40,7 +41,8 @@ export async function POST(req: NextRequest) {
const locale = (session!.user as { locale?: string }).locale ?? "en";
const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
substituteIngredient(parsed.data.ingredient, context, aiConfig, locale)
substituteIngredient(parsed.data.ingredient, context, aiConfig, locale),
{ skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
+10 -3
View File
@@ -3,8 +3,9 @@ import { z } from "zod";
import { and, eq } from "@epicure/db";
import { db, recipes, recipeIngredients, recipeSteps } from "@epicure/db";
import { requireSessionOrApiKey } from "@/lib/api-auth";
import { withAiQuota } from "@/lib/ai/ai-error";
import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
import { translateRecipe } from "@/lib/ai/features/translate-recipe";
import { withUserKey } from "@/lib/ai/resolve-user-key";
const Schema = z.object({
targetLanguage: z.string().min(2).max(50),
@@ -35,6 +36,12 @@ export async function POST(req: NextRequest, { params }: Params) {
return NextResponse.json({ error: "Validation error", issues: parsed.error.issues }, { status: 400 });
}
const configResult = await resolveAiConfigOrError(() =>
withUserKey(session!.user.id, { provider: parsed.data.provider, model: parsed.data.model })
);
if (!configResult.ok) return configResult.response;
const aiConfig = configResult.data;
const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
translateRecipe(
{
@@ -44,8 +51,8 @@ export async function POST(req: NextRequest, { params }: Params) {
steps: recipe.steps,
},
parsed.data.targetLanguage,
{ provider: parsed.data.provider, model: parsed.data.model }
)
aiConfig
), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;
const translation = result.data;
@@ -59,7 +59,7 @@ export async function POST(req: NextRequest, { params }: Params) {
{ ...aiConfig, userContext: privateBio ?? undefined },
parsed.data.directions,
(session!.user as { locale?: string }).locale ?? "en"
)
), { skipQuota: aiConfig.isByok }
);
if (!result.ok) return result.response;