arnaudne/Epicure
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: docker build crash when STORAGE_PUBLIC_URL unset

Browse Source 
compose.prod.yml passes STORAGE_PUBLIC_URL through ${STORAGE_PUBLIC_URL}
build args/env — when unset in .env.production, docker-compose
substitutes an empty string, not an absent var. ?? only falls back on
null/undefined, so next.config.ts's `new URL("")` threw and failed the
whole `pnpm --filter web build` step. Switched to || in next.config.ts
and lib/storage.ts so empty string also falls back to the default.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Arnaud
2026-07-12 12:16:11 +02:00
parent 83d18f5ad4
commit 321507b570
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/lib/storage.ts
+3 -3
View File
@@ -1,9 +1,9 @@
import { S3Client, PutObjectCommand, DeleteObjectCommand } from "@aws-sdk/client-s3";
import { getSignedUrl } from "@aws-sdk/s3-request-presigner";
const bucket = process.env["STORAGE_BUCKET"] ?? "epicure-uploads";
const endpoint = process.env["STORAGE_ENDPOINT"] ?? "http://localhost:9000";
const publicUrl = process.env["STORAGE_PUBLIC_URL"] ?? "http://localhost:9000";
const bucket = process.env["STORAGE_BUCKET"] || "epicure-uploads";
const endpoint = process.env["STORAGE_ENDPOINT"] || "http://localhost:9000";
const publicUrl = process.env["STORAGE_PUBLIC_URL"] || "http://localhost:9000";
const credentials = {
accessKeyId: process.env["STORAGE_ACCESS_KEY"] ?? "minioadmin",
apps/web/next.config.ts
+1 -1
View File
@@ -1,6 +1,6 @@
import type { NextConfig } from "next";
const storagePublicUrl = process.env["STORAGE_PUBLIC_URL"] ?? "http://localhost:9000";
const storagePublicUrl = process.env["STORAGE_PUBLIC_URL"] || "http://localhost:9000";
const storageUrl = new URL(storagePublicUrl);
const storageOrigin = storageUrl.origin;