fix: audit fixes — tier-quota bypass, webhook SSRF, auth hardening, pagination, a11y
Full audit (bugs/UI-UX/backend/feature-gap) turned up a money-leak AI quota bypass, webhook SSRF, and a long tail of missing pagination/auth/a11y work. Fixes land together since HANDOFF.md tracked them as one backlog. - AI routes charge tier quota before generating; nutrition POST is author-only - Webhook dispatch re-validates URL per delivery (SSRF/DNS-rebinding), treats redirects as failures; recipe.published now actually dispatches - New indexes/unique constraints on recipes, meal-planning, comments FK cascade - Recipe PUT/restore snapshot only inside the transaction, after validation - Recipe DELETE cleans up S3 objects (recipe + review photos) - Optimistic UI (favorite/star/follow/shopping-list) rolls back on failure - Upload presign enforces file size cap + per-tier storage quota - Route-level loading/error/not-found states across (app), admin, and root - middleware.ts guards (app)/admin; requireAdmin checks DB role, not cached session; rate limiting applied to both session and API-key branches, bucketed per key; Stripe webhook dedupes by event id - Pagination added to recipes, feed, profile, comments, pantry, admin tables - Nav shows real avatar + profile link + dark-mode toggle; destructive actions standardized on AlertDialog - Unsaved-changes guard + real ingredient/step validation on recipe form; canonical /recipes/[id] used in-app; next/image migration; aria-labels and alt text across icon buttons, avatars, recipe photos - packages/api-types removed (zero callers, too drifted to safely rewire); openapi.ts and ai-keys error shape drift fixed; BYOK decrypt failures now surface instead of silently falling back to the platform key Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -2,15 +2,19 @@ import crypto from "crypto";
|
||||
import { db } from "@epicure/db";
|
||||
import { webhooks, webhookDeliveries } from "@epicure/db";
|
||||
import { eq, and } from "@epicure/db";
|
||||
import { validateWebhookUrl } from "@/lib/validate-webhook-url";
|
||||
|
||||
export type WebhookEvent =
|
||||
| "recipe.created"
|
||||
| "recipe.updated"
|
||||
| "recipe.published"
|
||||
| "recipe.deleted"
|
||||
| "meal_plan.updated"
|
||||
| "shopping_list.completed"
|
||||
| "comment.added";
|
||||
export const WEBHOOK_EVENTS = [
|
||||
"recipe.created",
|
||||
"recipe.updated",
|
||||
"recipe.published",
|
||||
"recipe.deleted",
|
||||
"meal_plan.updated",
|
||||
"shopping_list.completed",
|
||||
"comment.added",
|
||||
] as const;
|
||||
|
||||
export type WebhookEvent = (typeof WEBHOOK_EVENTS)[number];
|
||||
|
||||
export async function dispatchWebhook(userId: string, event: WebhookEvent, payload: object) {
|
||||
const hooks = await db
|
||||
@@ -27,6 +31,11 @@ export async function dispatchWebhook(userId: string, event: WebhookEvent, paylo
|
||||
let statusCode = 0;
|
||||
let success = false;
|
||||
try {
|
||||
// Re-validate at dispatch time to defeat DNS rebinding between create and
|
||||
// dispatch. A small window remains between this lookup and fetch's own
|
||||
// resolution of the hostname — accepted for now.
|
||||
const ssrfError = await validateWebhookUrl(hook.url);
|
||||
if (ssrfError) throw new Error(ssrfError);
|
||||
const res = await fetch(hook.url, {
|
||||
method: "POST",
|
||||
headers: {
|
||||
@@ -35,6 +44,8 @@ export async function dispatchWebhook(userId: string, event: WebhookEvent, paylo
|
||||
"X-Epicure-Event": event,
|
||||
},
|
||||
body,
|
||||
// Redirects could point at internal services, so treat 3xx as failure.
|
||||
redirect: "manual",
|
||||
signal: AbortSignal.timeout(10000),
|
||||
});
|
||||
statusCode = res.status;
|
||||
|
||||
Reference in New Issue
Block a user