fix: password sign-in for 2FA accounts could silently bounce to /login (v0.50.1)
signIn.email() resolves with error: null and data.twoFactorRedirect: true
for 2FA-enabled accounts — no full session exists yet. The login page's
handleSubmit treated any non-error response as fully signed in and called
router.push("/recipes"), racing better-auth's own window.location.href
redirect to /verify-2fa (twoFactorClient's onSuccess hook). When the app's
push won that race, middleware bounced the unauthenticated /recipes
request straight back to /login with no error surfaced — looked like the
page just reloaded.
Now explicitly skips the /recipes push when twoFactorRedirect is set,
leaving the SDK's own redirect to run uncontested.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -2,6 +2,11 @@
|
|||||||
|
|
||||||
All notable changes to Epicure are documented here. This file is mirrored in-app at `/changelog` (and in the admin dashboard) via `apps/web/lib/changelog.ts` — update both together.
|
All notable changes to Epicure are documented here. This file is mirrored in-app at `/changelog` (and in the admin dashboard) via `apps/web/lib/changelog.ts` — update both together.
|
||||||
|
|
||||||
|
## 0.50.1 — 2026-07-19 09:30
|
||||||
|
|
||||||
|
### Fixed
|
||||||
|
- Password sign-in for 2FA-enabled accounts could silently bounce back to the login page with no error shown — the app was pushing straight to /recipes on any non-error sign-in response, racing the SDK's own redirect to the 2FA code screen and sometimes losing. Now waits for that case explicitly.
|
||||||
|
|
||||||
## 0.50.0 — 2026-07-18 14:20
|
## 0.50.0 — 2026-07-18 14:20
|
||||||
|
|
||||||
### Added
|
### Added
|
||||||
|
|||||||
@@ -25,7 +25,7 @@ export default function LoginPage() {
|
|||||||
e.preventDefault();
|
e.preventDefault();
|
||||||
setUnverified(false);
|
setUnverified(false);
|
||||||
setLoading(true);
|
setLoading(true);
|
||||||
const { error } = await authClient.signIn.email({ email, password, callbackURL: "/recipes" });
|
const { data, error } = await authClient.signIn.email({ email, password, callbackURL: "/recipes" });
|
||||||
setLoading(false);
|
setLoading(false);
|
||||||
if (error) {
|
if (error) {
|
||||||
if (error.code === "EMAIL_NOT_VERIFIED") {
|
if (error.code === "EMAIL_NOT_VERIFIED") {
|
||||||
@@ -33,7 +33,11 @@ export default function LoginPage() {
|
|||||||
} else {
|
} else {
|
||||||
toast.error(error.message ?? "Sign in failed");
|
toast.error(error.message ?? "Sign in failed");
|
||||||
}
|
}
|
||||||
} else {
|
} else if (!(data as { twoFactorRedirect?: boolean } | null)?.twoFactorRedirect) {
|
||||||
|
// 2FA-enabled accounts resolve with no `error` but `twoFactorRedirect: true` —
|
||||||
|
// no full session exists yet, so pushing to /recipes here races the SDK's own
|
||||||
|
// window.location.href to /verify-2fa (see twoFactorClient's onSuccess hook)
|
||||||
|
// and can lose, bouncing off middleware back to /login with no visible error.
|
||||||
router.push("/recipes");
|
router.push("/recipes");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
// Mirrors CHANGELOG.md at the repo root — update both together.
|
// Mirrors CHANGELOG.md at the repo root — update both together.
|
||||||
export const APP_VERSION = "0.50.0";
|
export const APP_VERSION = "0.50.1";
|
||||||
|
|
||||||
export type ChangelogEntry = {
|
export type ChangelogEntry = {
|
||||||
version: string;
|
version: string;
|
||||||
@@ -11,6 +11,13 @@ export type ChangelogEntry = {
|
|||||||
};
|
};
|
||||||
|
|
||||||
export const CHANGELOG: ChangelogEntry[] = [
|
export const CHANGELOG: ChangelogEntry[] = [
|
||||||
|
{
|
||||||
|
version: "0.50.1",
|
||||||
|
date: "2026-07-19 09:30",
|
||||||
|
fixed: [
|
||||||
|
"Password sign-in for 2FA-enabled accounts could silently bounce back to the login page with no error shown — the app was pushing straight to /recipes on any non-error sign-in response, racing the SDK's own redirect to the 2FA code screen and sometimes losing. Now waits for that case explicitly.",
|
||||||
|
],
|
||||||
|
},
|
||||||
{
|
{
|
||||||
version: "0.50.0",
|
version: "0.50.0",
|
||||||
date: "2026-07-18 14:20",
|
date: "2026-07-18 14:20",
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "@epicure/web",
|
"name": "@epicure/web",
|
||||||
"version": "0.50.0",
|
"version": "0.50.1",
|
||||||
"private": true,
|
"private": true,
|
||||||
"scripts": {
|
"scripts": {
|
||||||
"dev": "next dev",
|
"dev": "next dev",
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "epicure",
|
"name": "epicure",
|
||||||
"version": "0.50.0",
|
"version": "0.50.1",
|
||||||
"private": true,
|
"private": true,
|
||||||
"scripts": {
|
"scripts": {
|
||||||
"dev": "pnpm --filter web dev",
|
"dev": "pnpm --filter web dev",
|
||||||
|
|||||||
Reference in New Issue
Block a user