Arnaud
7626f1b496
Security audit fixes (see SECURITY_AUDIT.md): - lib/tiers.ts: checkAndIncrementTierLimit's recipe/storage branches did a live count/sum check with no lock tying it to the later write, so two concurrent requests near the cap could both pass and both write past the limit. Added checkTierLimitInTransaction — holds a per-user Postgres advisory lock for the duration of the caller's transaction, so the check and the write are atomic together. Applied to every recipe/storage write path (recipes create/update, fork, rate, avatar, and 7 AI recipe-creation routes). - Adversarial re-verification of that fix caught a bigger gap in the same area: four AI routes (photo import, idea generation, batch-cook, translate-to-new-draft) had no recipe-limit check at all. Fixed. - Added missing per-user rate limits to 5 AI endpoints (adapt, drinks, pairings, translate, variations) that had none, unlike their siblings. - search page now checks for a session server-side, matching every other page under (app)/ — defense in depth; the underlying API was already public by design and proxy.ts already blocked unauthenticated requests. - admin/settings route now uses the shared requireAdmin instead of a local duplicate. - Documented two admin support-ticket endpoints missing from the OpenAPI spec; verified full route/OpenAPI parity otherwise. - Bumped drizzle-orm to fix a SQL-identifier-escaping CVE, and overrode two transitive deps (esbuild, postcss) with known CVEs. pnpm audit is clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
56 lines
1.6 KiB
TypeScript
56 lines
1.6 KiB
TypeScript
import { type NextRequest, NextResponse } from "next/server";
|
|
import { db, auditLogs } from "@epicure/db";
|
|
import { requireAdmin } from "@/lib/api-auth";
|
|
import { setSiteSetting, type SiteSettingKey } from "@/lib/site-settings";
|
|
import { randomUUID } from "crypto";
|
|
|
|
const ALLOWED_KEYS: SiteSettingKey[] = [
|
|
"OPENAI_API_KEY",
|
|
"ANTHROPIC_API_KEY",
|
|
"OPENROUTER_API_KEY",
|
|
"OPENROUTER_DEFAULT_MODEL",
|
|
"OLLAMA_BASE_URL",
|
|
"NEXT_PUBLIC_VAPID_PUBLIC_KEY",
|
|
"VAPID_PRIVATE_KEY",
|
|
"SIGNUPS_DISABLED",
|
|
"DEFAULT_TEXT_PROVIDER",
|
|
"DEFAULT_TEXT_MODEL",
|
|
"DEFAULT_VISION_PROVIDER",
|
|
"DEFAULT_VISION_MODEL",
|
|
"DEFAULT_MEAL_PLAN_PROVIDER",
|
|
"DEFAULT_MEAL_PLAN_MODEL",
|
|
"DEFAULT_CHAT_PROVIDER",
|
|
"DEFAULT_CHAT_MODEL",
|
|
"AI_TOOL_CALLING_ENABLED",
|
|
"GITEA_URL",
|
|
"GITEA_TOKEN",
|
|
"GITEA_REPO",
|
|
];
|
|
|
|
export async function PUT(req: NextRequest) {
|
|
const { session, response } = await requireAdmin();
|
|
if (response) return response;
|
|
|
|
const body = (await req.json()) as Record<string, string | null>;
|
|
|
|
const changed: string[] = [];
|
|
for (const [key, value] of Object.entries(body)) {
|
|
if (!ALLOWED_KEYS.includes(key as SiteSettingKey)) continue;
|
|
await setSiteSetting(key as SiteSettingKey, value, session!.user.id);
|
|
changed.push(key);
|
|
}
|
|
|
|
if (changed.length > 0) {
|
|
await db.insert(auditLogs).values({
|
|
id: randomUUID(),
|
|
userId: session!.user.id,
|
|
action: "admin.settings.update",
|
|
targetType: "site_settings",
|
|
metadata: JSON.stringify({ keys: changed }),
|
|
createdAt: new Date(),
|
|
});
|
|
}
|
|
|
|
return NextResponse.json({ ok: true });
|
|
}
|