Files
Epicure/apps/web/app/api/v1/webhooks/[id]/route.ts
T
Arnaud 362f65656b fix: audit fixes — tier-quota bypass, webhook SSRF, auth hardening, pagination, a11y
Full audit (bugs/UI-UX/backend/feature-gap) turned up a money-leak AI quota
bypass, webhook SSRF, and a long tail of missing pagination/auth/a11y work.
Fixes land together since HANDOFF.md tracked them as one backlog.

- AI routes charge tier quota before generating; nutrition POST is author-only
- Webhook dispatch re-validates URL per delivery (SSRF/DNS-rebinding), treats
  redirects as failures; recipe.published now actually dispatches
- New indexes/unique constraints on recipes, meal-planning, comments FK cascade
- Recipe PUT/restore snapshot only inside the transaction, after validation
- Recipe DELETE cleans up S3 objects (recipe + review photos)
- Optimistic UI (favorite/star/follow/shopping-list) rolls back on failure
- Upload presign enforces file size cap + per-tier storage quota
- Route-level loading/error/not-found states across (app), admin, and root
- middleware.ts guards (app)/admin; requireAdmin checks DB role, not cached
  session; rate limiting applied to both session and API-key branches,
  bucketed per key; Stripe webhook dedupes by event id
- Pagination added to recipes, feed, profile, comments, pantry, admin tables
- Nav shows real avatar + profile link + dark-mode toggle; destructive actions
  standardized on AlertDialog
- Unsaved-changes guard + real ingredient/step validation on recipe form;
  canonical /recipes/[id] used in-app; next/image migration; aria-labels and
  alt text across icon buttons, avatars, recipe photos
- packages/api-types removed (zero callers, too drifted to safely rewire);
  openapi.ts and ai-keys error shape drift fixed; BYOK decrypt failures now
  surface instead of silently falling back to the platform key

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-09 21:50:35 +02:00

104 lines
2.9 KiB
TypeScript

import { NextRequest, NextResponse } from "next/server";
import { z } from "zod";
import { db, webhooks, eq, and } from "@epicure/db";
import { requireSession } from "@/lib/api-auth";
import { validateWebhookUrl } from "@/lib/validate-webhook-url";
import { WEBHOOK_EVENTS } from "@/lib/webhooks";
const UpdateWebhookBody = z.object({
url: z.string().min(1).max(2048).optional(),
events: z.array(z.enum(WEBHOOK_EVENTS)).optional(),
active: z.boolean().optional(),
});
export async function DELETE(
_req: NextRequest,
{ params }: { params: Promise<{ id: string }> }
) {
const { session, response } = await requireSession();
if (response) return response;
const { id } = await params;
const existing = await db
.select({ id: webhooks.id })
.from(webhooks)
.where(and(eq(webhooks.id, id), eq(webhooks.userId, session!.user.id)))
.limit(1);
if (existing.length === 0) {
return NextResponse.json({ error: "Not found" }, { status: 404 });
}
await db
.delete(webhooks)
.where(and(eq(webhooks.id, id), eq(webhooks.userId, session!.user.id)));
return new NextResponse(null, { status: 204 });
}
export async function PATCH(
req: NextRequest,
{ params }: { params: Promise<{ id: string }> }
) {
const { session, response } = await requireSession();
if (response) return response;
const { id } = await params;
const existing = await db
.select({ id: webhooks.id })
.from(webhooks)
.where(and(eq(webhooks.id, id), eq(webhooks.userId, session!.user.id)))
.limit(1);
if (existing.length === 0) {
return NextResponse.json({ error: "Not found" }, { status: 404 });
}
const body = await req.json() as unknown;
const parsed = UpdateWebhookBody.safeParse(body);
if (!parsed.success) {
return NextResponse.json(
{ error: "Validation error", issues: parsed.error.issues },
{ status: 400 }
);
}
if (parsed.data.url) {
const ssrfError = await validateWebhookUrl(parsed.data.url);
if (ssrfError) {
return NextResponse.json({ error: ssrfError }, { status: 400 });
}
}
const updates: Partial<{ url: string; events: string[]; active: boolean }> = {};
if (parsed.data.url !== undefined) updates.url = parsed.data.url;
if (parsed.data.events !== undefined) updates.events = parsed.data.events;
if (parsed.data.active !== undefined) updates.active = parsed.data.active;
if (Object.keys(updates).length === 0) {
return NextResponse.json({ error: "No fields to update" }, { status: 400 });
}
await db
.update(webhooks)
.set(updates)
.where(and(eq(webhooks.id, id), eq(webhooks.userId, session!.user.id)));
const updated = await db
.select({
id: webhooks.id,
userId: webhooks.userId,
url: webhooks.url,
events: webhooks.events,
active: webhooks.active,
createdAt: webhooks.createdAt,
})
.from(webhooks)
.where(eq(webhooks.id, id))
.limit(1);
return NextResponse.json(updated[0]);
}