362f65656b
Full audit (bugs/UI-UX/backend/feature-gap) turned up a money-leak AI quota bypass, webhook SSRF, and a long tail of missing pagination/auth/a11y work. Fixes land together since HANDOFF.md tracked them as one backlog. - AI routes charge tier quota before generating; nutrition POST is author-only - Webhook dispatch re-validates URL per delivery (SSRF/DNS-rebinding), treats redirects as failures; recipe.published now actually dispatches - New indexes/unique constraints on recipes, meal-planning, comments FK cascade - Recipe PUT/restore snapshot only inside the transaction, after validation - Recipe DELETE cleans up S3 objects (recipe + review photos) - Optimistic UI (favorite/star/follow/shopping-list) rolls back on failure - Upload presign enforces file size cap + per-tier storage quota - Route-level loading/error/not-found states across (app), admin, and root - middleware.ts guards (app)/admin; requireAdmin checks DB role, not cached session; rate limiting applied to both session and API-key branches, bucketed per key; Stripe webhook dedupes by event id - Pagination added to recipes, feed, profile, comments, pantry, admin tables - Nav shows real avatar + profile link + dark-mode toggle; destructive actions standardized on AlertDialog - Unsaved-changes guard + real ingredient/step validation on recipe form; canonical /recipes/[id] used in-app; next/image migration; aria-labels and alt text across icon buttons, avatars, recipe photos - packages/api-types removed (zero callers, too drifted to safely rewire); openapi.ts and ai-keys error shape drift fixed; BYOK decrypt failures now surface instead of silently falling back to the platform key Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
69 lines
2.3 KiB
TypeScript
69 lines
2.3 KiB
TypeScript
import crypto from "crypto";
|
|
import { db } from "@epicure/db";
|
|
import { webhooks, webhookDeliveries } from "@epicure/db";
|
|
import { eq, and } from "@epicure/db";
|
|
import { validateWebhookUrl } from "@/lib/validate-webhook-url";
|
|
|
|
export const WEBHOOK_EVENTS = [
|
|
"recipe.created",
|
|
"recipe.updated",
|
|
"recipe.published",
|
|
"recipe.deleted",
|
|
"meal_plan.updated",
|
|
"shopping_list.completed",
|
|
"comment.added",
|
|
] as const;
|
|
|
|
export type WebhookEvent = (typeof WEBHOOK_EVENTS)[number];
|
|
|
|
export async function dispatchWebhook(userId: string, event: WebhookEvent, payload: object) {
|
|
const hooks = await db
|
|
.select()
|
|
.from(webhooks)
|
|
.where(and(eq(webhooks.userId, userId), eq(webhooks.active, true)));
|
|
|
|
const filtered = hooks.filter((h) => h.events.length === 0 || h.events.includes(event));
|
|
|
|
await Promise.allSettled(
|
|
filtered.map(async (hook) => {
|
|
const body = JSON.stringify({ event, payload, timestamp: new Date().toISOString() });
|
|
const sig = crypto.createHmac("sha256", hook.secret).update(body).digest("hex");
|
|
let statusCode = 0;
|
|
let success = false;
|
|
try {
|
|
// Re-validate at dispatch time to defeat DNS rebinding between create and
|
|
// dispatch. A small window remains between this lookup and fetch's own
|
|
// resolution of the hostname — accepted for now.
|
|
const ssrfError = await validateWebhookUrl(hook.url);
|
|
if (ssrfError) throw new Error(ssrfError);
|
|
const res = await fetch(hook.url, {
|
|
method: "POST",
|
|
headers: {
|
|
"Content-Type": "application/json",
|
|
"X-Epicure-Signature": `sha256=${sig}`,
|
|
"X-Epicure-Event": event,
|
|
},
|
|
body,
|
|
// Redirects could point at internal services, so treat 3xx as failure.
|
|
redirect: "manual",
|
|
signal: AbortSignal.timeout(10000),
|
|
});
|
|
statusCode = res.status;
|
|
success = res.ok;
|
|
} catch {
|
|
// delivery failed; statusCode stays 0, success stays false
|
|
}
|
|
await db.insert(webhookDeliveries).values({
|
|
id: crypto.randomUUID(),
|
|
webhookId: hook.id,
|
|
event,
|
|
payload: payload as Record<string, unknown>,
|
|
statusCode,
|
|
success,
|
|
attempts: 1,
|
|
createdAt: new Date(),
|
|
});
|
|
})
|
|
);
|
|
}
|